Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/error interfaces #245

Merged
merged 5 commits into from
Mar 7, 2024
Merged

Feature/error interfaces #245

merged 5 commits into from
Mar 7, 2024

Conversation

johnabass
Copy link
Contributor

Added an optional error interface that errors can implement to better categorize what they are. This will avoid having to know about a litany of concrete error types when trying to decide what action to take in the event of a security error.

Copy link

codecov bot commented Mar 6, 2024

Codecov Report

Attention: Patch coverage is 75.67568% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 32.74%. Comparing base (2ab6b16) to head (0c5b72b).
Report is 1 commits behind head on main.

Files Patch % Lines
basculehttp/error.go 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #245      +/-   ##
==========================================
+ Coverage   32.02%   32.74%   +0.71%     
==========================================
  Files          14       15       +1     
  Lines         434      452      +18     
==========================================
+ Hits          139      148       +9     
- Misses        295      304       +9     
Flag Coverage Δ
unittests 32.74% <75.67%> (+0.71%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johnabass johnabass merged commit 85e0935 into main Mar 7, 2024
15 of 17 checks passed
@johnabass johnabass deleted the feature/error-interfaces branch March 7, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant