Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/generic workflow #279

Merged
merged 12 commits into from
Aug 15, 2024
Merged

Feature/generic workflow #279

merged 12 commits into from
Aug 15, 2024

Conversation

johnabass
Copy link
Contributor

Moved the core workflow up the base package

Copy link

codecov bot commented Aug 15, 2024

Codecov Report

Attention: Patch coverage is 94.01709% with 7 lines in your changes missing coverage. Please review.

Project coverage is 78.96%. Comparing base (cf754b0) to head (06d72f6).
Report is 14 commits behind head on main.

Files Patch % Lines
basculehttp/middleware.go 30.00% 6 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #279      +/-   ##
==========================================
+ Coverage   75.05%   78.96%   +3.91%     
==========================================
  Files          15       16       +1     
  Lines         481      542      +61     
==========================================
+ Hits          361      428      +67     
+ Misses        109      104       -5     
+ Partials       11       10       -1     
Flag Coverage Δ
unittests 78.96% <94.01%> (+3.91%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@piccione99 piccione99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks nice and clean and flexible to me. looking forward to the examples!

@johnabass johnabass merged commit 58b9aab into main Aug 15, 2024
18 checks passed
@johnabass johnabass deleted the feature/generic-workflow branch August 15, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants