Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/password hashing #291

Merged
merged 13 commits into from
Sep 3, 2024
Merged

Feature/password hashing #291

merged 13 commits into from
Sep 3, 2024

Conversation

johnabass
Copy link
Contributor

This PR adds basic password hashing support. The password hashing is modular and extensible, and currently only bcrypt is supported because it's easy.

Included is also a command-line tool for generating hashes in the OpenSSL crypt format. We can use that command to nab the string that should be put into configuration files for servers that accept basic auth or other password-like secrets. The configuration files no longer need to be closed source or encrypted, as any secrets will be one-way hashed.

Copy link

codecov bot commented Aug 30, 2024

Codecov Report

Attention: Patch coverage is 96.07843% with 2 lines in your changes missing coverage. Please review.

Project coverage is 99.76%. Comparing base (af4b32b) to head (a94899c).
Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
cmd/hash/main.go 90.47% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##              main     #291      +/-   ##
===========================================
- Coverage   100.00%   99.76%   -0.24%     
===========================================
  Files           21       25       +4     
  Lines          789      840      +51     
===========================================
+ Hits           789      838      +49     
- Misses           0        2       +2     
Flag Coverage Δ
unittests 99.76% <96.07%> (-0.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johnabass johnabass merged commit 2ff7372 into main Sep 3, 2024
13 checks passed
@johnabass johnabass deleted the feature/password-hashing branch September 3, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants