Skip to content

Commit

Permalink
Merge pull request #119 from Comcast/remove-outbound-sender-worker-pool
Browse files Browse the repository at this point in the history
Remove the outbound worker pool and replace it with short lived gorou…
  • Loading branch information
schmidtw authored Feb 19, 2019
2 parents 98a97d0 + 07c37ed commit 2666acf
Show file tree
Hide file tree
Showing 9 changed files with 245 additions and 391 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).

## [Unreleased]
- Remove the worker pool as a fixed number of workers per endpoint and simply cap
the maximum number.
- Fix for webhook shallow copy bug.
- Fix for delivering events as json or msgpack based events
- Fix for webhook update for all fields
- Fix for retry logic so all failures are retried the specified number of times
- Fix for waiting for DNS to resolve prior to listening for webhook updates
Expand Down
2 changes: 1 addition & 1 deletion src/caduceus/metrics.go
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ func Metrics() []xmetrics.Metric {
Name: DeliveryRetryCounter,
Help: "Number of delivery retries made",
Type: "counter",
LabelNames: []string{"url", "code", "event"},
LabelNames: []string{"url", "event"},
},
{
Name: DeliveryCounter,
Expand Down
Loading

0 comments on commit 2666acf

Please sign in to comment.