-
Notifications
You must be signed in to change notification settings - Fork 19
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Update the documents around contributing to the project.
- Loading branch information
Showing
3 changed files
with
33 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,31 @@ | ||
If you would like to contribute code to this project you can do so | ||
through GitHub by forking the repository and sending a pull request. | ||
Contribution Guidelines | ||
======================= | ||
|
||
Before Comcast accepts your code into the project you must sign the | ||
Comcast Contributor License Agreement ('CLA.pdf'). | ||
We love to see contributions to the project and have tried to make it easy to do so. If you would like to contribute code to this project you can do so through GitHub by forking the repository and sending a pull request. | ||
|
||
Before Comcast merges your code into the project you must sign the [Comcast Contributor License Agreement (CLA)](https://gist.github.com/ComcastOSS/a7b8933dd8e368535378cda25c92d19a). | ||
|
||
If you haven't previously signed a Comcast CLA, you'll automatically be asked to when you open a pull request. Alternatively, we can e-mail you a PDF that you can sign and scan back to us. Please send us an e-mail or create a new GitHub issue to request a PDF version of the CLA. | ||
|
||
For more details about contributing to GitHub projects see | ||
http://gun.io/blog/how-to-github-fork-branch-and-pull-request/ | ||
|
||
Documentation | ||
------------- | ||
|
||
If you contribute anything that changes the behavior of the | ||
application, document it in the [README](https://github.com/Comcast/caduceus/blob/master/README.md) or [wiki](https://github.com/Comcast/caduceus/wiki)! This includes new features, additional variants of behavior and breaking changes. | ||
|
||
Testing | ||
------- | ||
|
||
Tests are written using golang's standard testing tools, and are run prior to the PR being accepted. | ||
|
||
Pull Requests | ||
------------- | ||
|
||
* should be narrowly focused with no more than 3 or 4 logical commits | ||
* when possible, address no more than one issue | ||
* should be reviewable in the GitHub code review tool | ||
* should be linked to any issues it relates to (i.e. issue number after (#) in commit messages or pull request message) | ||
* should conform to idiomatic golang code formatting |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters