Merge pull request #42 from Comcast/feature/removeDnsReadyCode

Feature/removeDnsReadyCode

src/caduceus/caduceus.go

@@ -213,16 +213,10 @@ func caduceus(arguments []string) int {
 		return 1
 	}
 
-	// make sure dns is ready before preceeding
-	logger.Debug("Reaching out to see if DNS is ready.")
+	logger.Debug("calling webhookFactory.PrepareAndStart")
 	now := time.Now()
-	dnsReadyChan := make(chan bool, 1)
-	go caduceusHealth.dnsReady(selfURL.String(), dnsReadyChan)
-	<-dnsReadyChan
-	logger.Debug("DNS is ready. elapsed time: %v", time.Since(now))
-
-	// todo: add message
 	webhookFactory.PrepareAndStart()
+	logger.Debug("webhookFactory.PrepareAndStart done. elapsed time: %v", time.Since(now))
 
 	// Attempt to obtain the current listener list from current system without having to wait for listener reregistration.
 	logger.Debug("Attempting to obtain current listener list from %v", v.GetString("start.apiPath"))

src/caduceus/caduceus_type.go

@@ -6,7 +6,6 @@ import (
 	"github.com/Comcast/webpa-common/logging"
 	"github.com/Comcast/webpa-common/secure"
 	"github.com/Comcast/webpa-common/secure/key"
-	"net/http"
 	"time"
 )
 
@@ -124,24 +123,6 @@ func (ch *CaduceusHealth) IncrementBucket(inSize int) {
 	}
 }
 
-func (ch *CaduceusHealth) dnsReady(address string, ready chan bool) {
-	req, err := http.NewRequest("GET", address, nil)
-	if err != nil {
-		return
-	}
-	client := http.Client{}
-
-	var resp *http.Response
-	for resp == nil {
-		resp, err = client.Do(req)
-		if err == nil {
-			ready <- true
-			break
-		}
-		time.Sleep(time.Second * 1)  // wait a moment between queries
-	}
-}
-
 // Below is the struct and implementation of our worker pool factory
 type WorkerPoolFactory struct {
 	NumWorkers int

src/glide.yaml

@@ -1,7 +1,7 @@
 package: .
 import:
 - package: github.com/Comcast/webpa-common
-  version: 2943129fb5ff4723c43aeee7e6b36b5e00e46c47
+  version: 0ed5d670f2e9fd8047e21f3765d4b0f5c7895a31
   subpackages:
   - concurrent
   - handler