Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the expired metric to explicitly cover only messages that expi… #156

Merged
merged 2 commits into from
Aug 29, 2019

Conversation

schmidtw
Copy link
Member

…re in the queue. A new label is present for prior to queueing.

Help debug Issue #145 .

…re in the queue. A new label is present for prior to queueing.
@codecov-io
Copy link

codecov-io commented Aug 29, 2019

Codecov Report

Merging #156 into master will increase coverage by 1.99%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #156      +/-   ##
==========================================
+ Coverage   68.95%   70.94%   +1.99%     
==========================================
  Files           7        7              
  Lines         670      716      +46     
==========================================
+ Hits          462      508      +46     
+ Misses        196      195       -1     
- Partials       12       13       +1
Impacted Files Coverage Δ
src/caduceus/outboundSender.go 82.17% <100%> (-0.48%) ⬇️
src/caduceus/metrics.go 100% <100%> (ø) ⬆️
src/caduceus/senderWrapper.go 85.54% <0%> (+3.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58479b0...80d71df. Read the comment docs.

@schmidtw schmidtw merged commit f96ad60 into master Aug 29, 2019
@schmidtw schmidtw deleted the update-metrics branch August 29, 2019 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants