Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Ancla Dependecies from whole package and Bascule Dependencies from fx portion of app #432

Merged
merged 14 commits into from
Jan 10, 2024

Conversation

maurafortino
Copy link
Contributor

@maurafortino maurafortino commented Dec 12, 2023

What's Included:

  • removed/commented out ancla; spoke with Wes and John and they want to removed the argus/ancla dependency. Wes said to not focus on adding any of the ancla functionality for now
  • removed bascule from main.go (remains in the old functionality); Wes confirmed that we should wait until new bascule to do anything with bascule/auth.

PR #433 should be merged first

@maurafortino maurafortino self-assigned this Dec 12, 2023
@maurafortino maurafortino changed the title Ancla Remove Ancla Dependecies from whole package and Bascule Dependencies from fx portion of app Dec 12, 2023
Copy link

codecov bot commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (denopink/feat/rewrite@e04baf4). Click here to learn what that means.

❗ Current head 28b0b22 differs from pull request most recent head 5242d5f. Consider uploading reports for the commit 5242d5f to get more accurate results

Additional details and impacted files
@@                   Coverage Diff                    @@
##             denopink/feat/rewrite     #432   +/-   ##
========================================================
  Coverage                         ?   31.09%           
========================================================
  Files                            ?       12           
  Lines                            ?     1103           
  Branches                         ?        0           
========================================================
  Hits                             ?      343           
  Misses                           ?      745           
  Partials                         ?       15           
Flag Coverage Δ
unittests 31.09% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

guardrails bot commented Dec 12, 2023

⚠️ We detected 6 security issues in this pull request:

Hard-Coded Secrets (1)
Severity Details Docs
Medium Title: Secret Keyword
secret := "placeholderSecret"
📚

More info on how to fix Hard-Coded Secrets in General.


Vulnerable Libraries (5)
Severity Details
N/A pkg:golang/github.com/xmidt-org/[email protected] - no patch available
N/A pkg:golang/github.com/xmidt-org/webpa-common/[email protected] - no patch available
N/A pkg:golang/github.com/spf13/[email protected] - no patch available
N/A pkg:golang/github.com/xmidt-org/[email protected] - no patch available
N/A pkg:golang/github.com/stretchr/[email protected] - no patch available

More info on how to fix Vulnerable Libraries in Go.


👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

@maurafortino maurafortino merged commit 49f5e5d into denopink/feat/rewrite Jan 10, 2024
11 of 14 checks passed
@maurafortino maurafortino deleted the ancla branch January 10, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants