Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated package structure to include internal package #478

Merged
merged 4 commits into from
Apr 15, 2024
Merged

updated package structure to include internal package #478

merged 4 commits into from
Apr 15, 2024

Conversation

maurafortino
Copy link
Contributor

Updated package structure to include internal and cmd packages

@maurafortino maurafortino requested a review from denopink April 10, 2024 15:04
@maurafortino maurafortino self-assigned this Apr 10, 2024
denopink
denopink reviewed Apr 10, 2024
View reviewed changes
cmd/main.go Show resolved Hide resolved
denopink
denopink reviewed Apr 10, 2024
View reviewed changes
caduceus.go Outdated Show resolved Hide resolved
denopink
denopink reviewed Apr 10, 2024
View reviewed changes
caduceus.go Outdated Show resolved Hide resolved
denopink
denopink reviewed Apr 10, 2024
View reviewed changes
caduceus.go Outdated Show resolved Hide resolved
denopink
denopink reviewed Apr 10, 2024
View reviewed changes
caduceus.go Outdated Show resolved Hide resolved
denopink
denopink reviewed Apr 10, 2024
View reviewed changes
caduceus.go Show resolved Hide resolved
denopink
denopink reviewed Apr 10, 2024
View reviewed changes
internal/handler/http.go Outdated Show resolved Hide resolved
denopink
denopink approved these changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@denopink denopink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a few suggestions, otherwise lgtm!

@maurafortino maurafortino requested a review from denopink April 11, 2024 15:22
@maurafortino maurafortino merged commit 15f8659 into denopink/feat/rewrite Apr 15, 2024
10 of 14 checks passed
@maurafortino maurafortino deleted the package-reorg branch April 15, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denopink denopink denopink approved these changes

Assignees

@maurafortino maurafortino

Labels
caduceus-refactor
Projects
XMiDT
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maurafortino @denopink