Matcher and Webhook Updates #487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
maurafortino
commented
Apr 30, 2024
maurafortino
commented
- removed the listener version check out of sender.Update
- added NewMatcher function: checks listener version, returns matcher interface, version and error
- added NewSink function: takes in config, version, id, and logger; returns sink interface
…ion check to matcher
denopink
reviewed
May 1, 2024
internal/sink/matcher.go
Outdated
| @@ -47,9 +47,24 @@ type CommonWebhook struct { | |||
| logger *zap.Logger | |||
| } | |||
|
|
|||
| func NewMatcher(l Listener, logger *zap.Logger) (matcher Matcher, version int, err error) { | |||
There was a problem hiding this comment.
this is more of an artifact from the past, let's take a note to review how loggers are used and passed around in caduceus in general
denopink
reviewed
May 1, 2024
denopink
reviewed
May 1, 2024
denopink
reviewed
May 1, 2024
denopink
requested changes
May 1, 2024
denopink
approved these changes
May 1, 2024
Vulnerable Libraries (1)
More info on how to fix Vulnerable Libraries in Go. 👉 Go to the dashboard for detailed results. 📥 Happy? Share your feedback with us. |
denopink
reviewed
Jun 13, 2024
denopink
reviewed
Jul 25, 2024
| Sink sink.Wrapper | ||
| } | ||
|
|
||
| func InitializeAncla(lifecycle fx.Lifecycle) fx.Option { |
There was a problem hiding this comment.
lets move this as a provide.go file in ancla 🙂
There was a problem hiding this comment.
going to work on in another PR
denopink
reviewed
Jul 25, 2024
denopink
reviewed
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.