Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft ancla helper edit #525

Closed
wants to merge 1 commit into from

Conversation

maurafortino
Copy link
Contributor

want to create a provide function for ancla (draft PR here: xmidt-org/ancla#236), but having issues with exporting and circular dependency

@maurafortino maurafortino requested a review from denopink July 25, 2024 16:07
@maurafortino maurafortino changed the base branch from main to denopink/feat/rewrite July 25, 2024 16:08
Copy link

guardrails bot commented Jul 25, 2024

⚠️ We detected 3 security issues in this pull request:

Hard-Coded Secrets (1)
Severity Details Docs
Medium Title: Secret Keyword
secret := "placeholderSecret"
📚

More info on how to fix Hard-Coded Secrets in General.


Insecure Network Communication (1)
Severity Details Docs
Medium Title: Insecure SSL/TLS versions allowed
TLSClientConfig: &tls.Config{InsecureSkipVerify: config.DisableClientHostnameValidation},
📚

More info on how to fix Insecure Network Communication in Go.


Vulnerable Libraries (1)
Severity Details
Medium pkg:golang/github.com/aws/[email protected] - no patch available

More info on how to fix Vulnerable Libraries in Go.


👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

@@ -13,48 +13,25 @@ import (
"go.uber.org/zap"
)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maurafortino
Copy link
Contributor Author

closing - created new PR for this

@maurafortino maurafortino deleted the draft-ancla-helper-edit branch December 13, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants