Draft ancla provide #526
Draft ancla provide #526
Conversation
| } | ||
|
|
||
| func InitializeAncla(lifecycle fx.Lifecycle) fx.Option { | ||
| return fx.Provide( | ||
| func(in AnclaListenerIn) ancla.ListenerConfig { |
There was a problem hiding this comment.
moved to anclaListenerIn and AnclaServiceIn to ancla (https://github.com/xmidt-org/ancla/pull/236/files#diff-c52daedaeda258db15ec11d57bbf299412a20328f6cd026980ef07f01960dd3aR189-R219)
There was a problem hiding this comment.
the provide functions are being called: https://github.com/xmidt-org/caduceus/pull/526/files#diff-305593783b1c45f15c0e2812db09596d4d8e8e52ae6403a36dbae45e54bcbfb3R161-R162
|
|
||
| func getLogger(ctx context.Context) *zap.Logger { |
There was a problem hiding this comment.
| @@ -141,6 +141,7 @@ func (sh *ServerHandler) ServeHTTP(response http.ResponseWriter, request *http.R | |||
| sh.handleRequest(sh.fixWrp(msg)) | |||
|
|
|||
| // return a 202 | |||
| //TODO: do we need to add error handling because i'm getting this response even when event had not been placed on queue | |||
There was a problem hiding this comment.
Depends how the code is setup...
for now a 202 is valid since the server [has] received the HTTP request and intends to process it (the meaning of 202) even tho it may fail in the down stream logic
There was a problem hiding this comment.
worth to make a note and come back
What's Included: