Feat/kafka #538
Merged
Feat/kafka #538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maurafortino
commented
Aug 27, 2024
maurafortino
commented
Aug 27, 2024
Closed
denopink
reviewed
Aug 29, 2024
internal/sink/sink.go
Outdated
| } | ||
|
|
||
| // Create a new Kafka producer | ||
| producer, err := sarama.NewSyncProducer(k.brokerAddr, k.config) |
There was a problem hiding this comment.
I think we want to cache the producer and not recreate it for every incoming event
denopink
reviewed
Aug 29, 2024
denopink
reviewed
Aug 29, 2024
denopink
reviewed
Aug 29, 2024
internal/sink/sink.go
Outdated
Comment on lines
75
to
80
| config := sarama.NewConfig() | ||
| config.Producer.Return.Successes = true | ||
| config.Producer.RequiredAcks = sarama.WaitForAll | ||
| config.Producer.Retry.Max = c.DeliveryRetries //should we be using retryhint for this? | ||
|
|
||
| kafka.config = config |
There was a problem hiding this comment.
Suggested change
| config := sarama.NewConfig() | |
| config.Producer.Return.Successes = true | |
| config.Producer.RequiredAcks = sarama.WaitForAll | |
| config.Producer.Retry.Max = c.DeliveryRetries //should we be using retryhint for this? | |
| kafka.config = config | |
| kafka.config.Producer.Return.Successes = true | |
| kafka.config.Producer.RequiredAcks = sarama.WaitForAll | |
| kafka.config.Producer.Retry.Max = c.DeliveryRetries //should we be using retryhint for this? |
There was a problem hiding this comment.
why are we getting rid of NewConfig?
denopink
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's Included:
TODO: