retryhttp client #592
Merged
retryhttp client #592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maurafortino
commented
Dec 18, 2024
| @@ -215,29 +215,6 @@ func getUrls(urls []string) (int, error) { | |||
|
|
|||
| } | |||
|
|
|||
| func (whs WebhookSink) Send(secret, acceptType string, msg *wrp.Message) error { | |||
There was a problem hiding this comment.
moved this down toward the v2 logic so that they are all together
maurafortino
commented
Dec 18, 2024
| @@ -650,22 +627,6 @@ func AddMessageHeaders(kafkaMsg *sarama.ProducerMessage, m *wrp.Message) { | |||
| } | |||
| } | |||
|
|
|||
| func (v2 *WebhookV2) Update(c Config, l *zap.Logger, altUrls []string, id, failureUrl, receiverUrl string) { | |||
There was a problem hiding this comment.
function wasn't being used
maurafortino
commented
Dec 18, 2024
internal/sink/srvRecordDialer.go
Outdated
There was a problem hiding this comment.
Note: we will be updating the logic for the LoadBalancingScheme in the next PR
maurafortino
changed the base branch from
webhook-v2
to
denopink/feat/rewrite
maurafortino
changed the base branch from
denopink/feat/rewrite
to
webhook-v2
denopink
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's Included: