Dns package rewrite #596
Draft
Dns package rewrite #596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y weight if there's multiple srvs with the same priority
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's Included
-updated the logic of the chooser so we only have a priority chooser
-priority chooser is sorted in ascending order
-map is created so that if there are mutliple srvs with the same priority they are grouped together
-we then choose an srv from those srvs based on their weight
Question: is this current logic even correct for a round robin choice?
Question: if correct: if there are multiple srvs for a priority and the one chosen fails do we want to try the other weights or do we just want to skip ahead to the next priority