Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use backoff retry for queues #47

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bill1600
Copy link
Collaborator

@bill1600 bill1600 commented May 3, 2019

stop using pthread_cond_timedwait for queues, but just backoff retry instead.
since we've been seeing crashes in pthread_cond_timedwait, test this version.

@bill1600 bill1600 requested a review from shilpa24balaji May 3, 2019 22:13
@codecov
Copy link

codecov bot commented May 3, 2019

Codecov Report

Merging #47 into master will increase coverage by 3.52%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #47      +/-   ##
==========================================
+ Coverage   62.44%   65.96%   +3.52%     
==========================================
  Files           3        3              
  Lines         639      620      -19     
  Branches      131      124       -7     
==========================================
+ Hits          399      409      +10     
+ Misses        165      142      -23     
+ Partials       75       69       -6
Impacted Files Coverage Δ
src/libparodus_queues.c 85.34% <100%> (+19.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcef57c...ce1b75b. Read the comment docs.

@codecov
Copy link

codecov bot commented May 3, 2019

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.96%. Comparing base (fcef57c) to head (ce1b75b).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #47      +/-   ##
==========================================
+ Coverage   62.44%   65.96%   +3.52%     
==========================================
  Files           3        3              
  Lines         639      620      -19     
  Branches      131      124       -7     
==========================================
+ Hits          399      409      +10     
+ Misses        165      142      -23     
+ Partials       75       69       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant