Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:Github workflow #253

Merged
merged 1 commit into from
Dec 6, 2023
Merged

fix:Github workflow #253

merged 1 commit into from
Dec 6, 2023

Conversation

nlrcomcast
Copy link
Contributor

No description provided.

Copy link

guardrails bot commented Dec 6, 2023

All previously detected findings have been fixed. Good job! 👍🎉

We will keep this comment up-to-date as you go along and notify you of any security issues that we identify.


👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Attention: 23 lines in your changes are missing coverage. Please review.

Comparison is base (a385998) 76.39% compared to head (ae4884b) 61.65%.
Report is 43 commits behind head on master.

Files Patch % Lines
source/app/libpd.c 0.00% 21 Missing ⚠️
tests/test_libpd.c 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #253       +/-   ##
===========================================
- Coverage   76.39%   61.65%   -14.74%     
===========================================
  Files          18        2       -16     
  Lines        6320      386     -5934     
===========================================
- Hits         4828      238     -4590     
+ Misses       1492      148     -1344     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nlrcomcast nlrcomcast closed this Dec 6, 2023
@nlrcomcast nlrcomcast reopened this Dec 6, 2023
add_executable(test_webpa_adapter test_webpa_adapter.c ../source/broadband/webpa_adapter.c)
target_link_libraries (test_webpa_adapter -lwrp-c -ldbus-1 -lccsp_common -lwdmp-c -lcjson ${WEBPA_COMMON_LIBS})
# #-------------------------------------------------------------------------------
# # test_webpa_adapter
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to fix test build issues for the disabled tests in upcoming PRs

@sadhyama sadhyama merged commit 71c2107 into xmidt-org:master Dec 6, 2023
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants