Skip to content

Commit

Permalink
Merge pull request #166 from xmidt-org/yaml-lint
Browse files Browse the repository at this point in the history
chore:Enable yaml linting.
  • Loading branch information
schmidtw authored May 29, 2024
2 parents 87af48d + 931a8a7 commit 84af961
Show file tree
Hide file tree
Showing 8 changed files with 56 additions and 17 deletions.
5 changes: 3 additions & 2 deletions .codecov.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
## SPDX-FileCopyrightText: 2016 Comcast Cable Communications Management, LLC
## SPDX-License-Identifier: Apache-2.0
# SPDX-FileCopyrightText: 2016 Comcast Cable Communications Management, LLC
# SPDX-License-Identifier: Apache-2.0
---
coverage:
range: 50..80
round: down
Expand Down
6 changes: 4 additions & 2 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,14 @@ updates:
- package-ecosystem: "github-actions"
directory: "/"
schedule:
# Check for updates to GitHub Actions every week
# Check for updates to GitHub Actions every day
interval: "daily"
labels:
- "dependencies"
commit-message:
prefix: "chore"
include: "scope"
open-pull-requests-limit: 10

- package-ecosystem: gomod
directory: /
Expand All @@ -22,5 +23,6 @@ updates:
labels:
- "dependencies"
commit-message:
prefix: "feat"
prefix: "chore"
include: "scope"
open-pull-requests-limit: 10
1 change: 1 addition & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,4 +23,5 @@ jobs:
uses: xmidt-org/shared-go/.github/workflows/ci.yml@c9c75b3fd850c64594bcdc7181b4f7557675faed # v4.4.0
with:
release-type: program
yaml-lint-skip: false
secrets: inherit
4 changes: 2 additions & 2 deletions .golangci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ linters:
- bodyclose
- dupl
- errorlint

- goconst
- gosec
- misspell
Expand All @@ -28,4 +28,4 @@ linters-settings:
# Report non-wrapping error creation using fmt.Errorf
errorf: false
misspell:
locale: US
locale: US
2 changes: 1 addition & 1 deletion .release/docker/petasos_spruce.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -308,6 +308,6 @@ tracing:
# so that trace information is not written to stdout.
# skipTraceExport: true

# endpoint is where trace information should be routed. Applies to otlp, zipkin, and jaegar. OTLP/gRPC uses port 4317 by default.
# endpoint is where trace information should be routed. Applies to otlp, zipkin, and jaegar. OTLP/gRPC uses port 4317 by default.
# OTLP/HTTP uses port 4318 by default.
endpoint: (( grab $TRACING_PROVIDER_ENDPOINT || "http://zipkin:9411/api/v2/spans" ))
10 changes: 4 additions & 6 deletions .release/helm/petasos/values.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
## SPDX-FileCopyrightText: 2016 Comcast Cable Communications Management, LLC
## SPDX-License-Identifier: Apache-2.0
# SPDX-FileCopyrightText: 2016 Comcast Cable Communications Management, LLC
# SPDX-License-Identifier: Apache-2.0
# Default values for xmitd-talaria.

---
petasos:
# docker image used
image: xmidt/petasos
Expand All @@ -22,9 +22,7 @@ pprof:
metric:
address:
host: ""
port: "6403"
port: "6403"

# Pull secret used when images are stored in a private repository
# imagePullSecretName:


38 changes: 38 additions & 0 deletions .yamllint.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
# SPDX-FileCopyrightText: 2024 Comcast Cable Communications Management, LLC
# SPDX-License-Identifier: Apache-2.0
---

extends: default

ignore:
- .release/helm/petasos/templates/petasos.yaml

rules:
braces:
level: warning
max-spaces-inside: 1
brackets:
level: warning
max-spaces-inside: 1
colons:
level: warning
max-spaces-after: -1
commas:
level: warning
comments: disable
comments-indentation: disable
document-start:
present: true
empty-lines:
max: 2
hyphens:
max-spaces-after: 1
indentation:
level: error
indent-sequences: consistent
line-length:
level: warning
max: 90
allow-non-breakable-words: true
allow-non-breakable-inline-mappings: true
truthy: disable
7 changes: 3 additions & 4 deletions petasos.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
## SPDX-FileCopyrightText: 2016 Comcast Cable Communications Management, LLC
## SPDX-License-Identifier: Apache-2.0
# SPDX-FileCopyrightText: 2016 Comcast Cable Communications Management, LLC
# SPDX-License-Identifier: Apache-2.0
---
# The unique fully-qualified-domain-name of the server. It is provided to
# the X-petasos-Server header for showing what server fulfilled the request
Expand Down Expand Up @@ -339,7 +339,6 @@ tracing:
# so that trace information is not written to stdout.
# skipTraceExport: true

# endpoint is where trace information should be routed. Applies to otlp, zipkin, and jaegar. OTLP/gRPC uses port 4317 by default.
# endpoint is where trace information should be routed. Applies to otlp, zipkin, and jaegar. OTLP/gRPC uses port 4317 by default.
# OTLP/HTTP uses port 4318 by default.
# endpoint: "http://localhost:9411/api/v2/spans"

0 comments on commit 84af961

Please sign in to comment.