Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Patch Failing Dockerfile #107

Merged
merged 9 commits into from
Oct 10, 2022
Merged

Bug: Patch Failing Dockerfile #107

merged 9 commits into from
Oct 10, 2022

Conversation

denopink
Copy link
Contributor

@denopink denopink commented Aug 31, 2022 •
edited by renaz6
Loading

What's included:

  • Patch failing build layers
  • Remove deprecated MAINTAINER
  • Fix linter issues

Fixes #109

https://github.com/comcast-cl/xmidt/issues/446
https://github.com/comcast-cl/xmidt/issues/435

New Work

#111

@denopink denopink added the bug label Aug 31, 2022
@denopink denopink self-assigned this Aug 31, 2022
@denopink denopink changed the title Update Dockerfile Bug: Patch Failing Dockerfile Aug 31, 2022
@guardrails
Copy link

guardrails bot commented Sep 8, 2022 •
edited
Loading

⚠️ We detected 5 security issues in this pull request:

Vulnerable Libraries (5)
Severity Details
Medium github.com/gorilla/sessions - no patch available
High github.com/hashicorp/consul/api upgrade to: 1.9.17, 1.10.10, 1.11.5
High pkg:golang/github.com/hashicorp/consul/[email protected]@v1.14.0 - no patch available
High pkg:golang/github.com/gorilla/[email protected]@v1.5.0 - no patch available
High pkg:golang/gopkg.in/[email protected]@v2.4.0 - no patch available

More info on how to fix Vulnerable Libraries in Go.

👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

@codecov
Copy link

codecov bot commented Sep 22, 2022 •
edited
Loading

Codecov Report

Merging #107 (e051283) into main (cf637d3) will not change coverage.
The diff coverage is 0.00%.

@@          Coverage Diff          @@
##            main    #107   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files          1       1           
  Lines        137     135    -2     
=====================================
+ Misses       137     135    -2
Flag Coverage Δ
unittests 0.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
main.go 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@renaz6 renaz6 requested review from schmidtw and johnabass October 10, 2022 15:31
@renaz6 renaz6 self-assigned this Oct 10, 2022
@renaz6 renaz6 assigned denopink and unassigned denopink Oct 10, 2022
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@denopink denopink merged commit 6c6d1ce into main Oct 10, 2022
@denopink denopink deleted the denopink/patch/golang-base-upgrade branch October 10, 2022 17:01
@denopink denopink mentioned this pull request Oct 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schmidtw schmidtw schmidtw approved these changes

@johnabass johnabass Awaiting requested review from johnabass

Assignees

@denopink denopink

@renaz6 renaz6

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Patch Failing Docker Image
3 participants
@denopink @schmidtw @renaz6