Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dockerfile for processor arch #270

Merged
merged 3 commits into from
May 3, 2023

Conversation

Zacharias
Copy link
Contributor

What is this PR out to accomplish?

By quizzing uname during build time we can ascertain the processor architecture the builder image is running under/as, and download an appropriate architecture's copy of spruce

Addresses #265

@CLAassistant
Copy link

CLAassistant commented May 3, 2023

CLA assistant check
All committers have signed the CLA.

@Zacharias Zacharias requested a review from schmidtw May 3, 2023 19:00
@codecov
Copy link

codecov bot commented May 3, 2023

Codecov Report

Merging #270 (7bad7a2) into main (f8c9f7c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #270   +/-   ##
=======================================
  Coverage   34.91%   34.91%           
=======================================
  Files           8        8           
  Lines         968      968           
=======================================
  Hits          338      338           
  Misses        628      628           
  Partials        2        2           
Flag Coverage Δ
unittests 34.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@schmidtw schmidtw merged commit f046067 into main May 3, 2023
@schmidtw schmidtw deleted the update-dockerfile-for-processor-arch branch May 3, 2023 19:13
@Zacharias Zacharias linked an issue May 4, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add configuration to allow for aarch64 hosts in Dockerfile
3 participants