Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch: fixed duplicated device removing itself bug (round two) #504

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

denopink
Copy link
Contributor

@denopink denopink commented Dec 5, 2024

- fixed bug where duplicated device would remove itself
- xmidt-org/webpa-common#439
@denopink denopink self-assigned this Dec 5, 2024
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.60%. Comparing base (b9f88b1) to head (eb86553).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #504   +/-   ##
=======================================
  Coverage   58.60%   58.60%           
=======================================
  Files          18       18           
  Lines        1872     1872           
=======================================
  Hits         1097     1097           
  Misses        733      733           
  Partials       42       42           
Flag Coverage Δ
unittests 58.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@denopink denopink merged commit 8418f50 into main Dec 5, 2024
19 checks passed
@denopink denopink deleted the denopink/patch/update-webpa-common branch December 5, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant