Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added certificate chain verification #254

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Conversation

johnabass
Copy link
Contributor

I think this will verify that peer certs are in the root CA chain, which is what's installed locally.

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 55.33%. Comparing base (b48cdb2) to head (e0c50d5).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
token/claimBuilder.go 66.66% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #254      +/-   ##
==========================================
+ Coverage   55.25%   55.33%   +0.07%     
==========================================
  Files          54       54              
  Lines        2320     2335      +15     
==========================================
+ Hits         1282     1292      +10     
- Misses       1011     1015       +4     
- Partials       27       28       +1     
Flag Coverage Δ
unittests 55.33% <66.66%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@schmidtw schmidtw merged commit 197ebc4 into main Nov 15, 2024
19 checks passed
@schmidtw schmidtw deleted the feature/check-cert-chain branch November 15, 2024 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants