Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Broken Metric Middleware Function #314

Merged
merged 3 commits into from
Oct 24, 2022
Merged

Fix Broken Metric Middleware Function #314

merged 3 commits into from
Oct 24, 2022

Conversation

renaz6
Copy link
Member

@renaz6 renaz6 commented Oct 17, 2022 •
edited
Loading

New Work

#315

@guardrails
Copy link

guardrails bot commented Oct 17, 2022 •
edited
Loading

⚠️ We detected 2 security issues in this pull request:

Vulnerable Libraries (2)
Severity Details
High pkg:golang/gopkg.in/[email protected]@v2.4.0 - no patch available
High pkg:golang/golang.org/x/[email protected]@v0.3.7 - no patch available

More info on how to fix Vulnerable Libraries in Go.

👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

@renaz6 renaz6 self-assigned this Oct 17, 2022
@codecov
Copy link

codecov bot commented Oct 17, 2022 •
edited
Loading

Codecov Report

Merging #314 (9488819) into main (3a4abfb) will increase coverage by 1.05%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #314      +/-   ##
==========================================
+ Coverage   43.61%   44.67%   +1.05%     
==========================================
  Files          15       15              
  Lines        1144     1117      -27     
==========================================
  Hits          499      499              
+ Misses        637      610      -27     
  Partials        8        8
Flag Coverage Δ
unittests 44.67% <0.00%> (+1.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
routes.go 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

denopink
denopink approved these changes Oct 17, 2022
View reviewed changes
Copy link
Contributor

@denopink denopink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@renaz6 renaz6 requested a review from njharter October 17, 2022 18:22
@renaz6 renaz6 changed the title Fix Metric Middleware Fix Broken Metric Middleware Function Oct 17, 2022
@denopink denopink force-pushed the renaz6/fixMetricMiddleware branch from 3e349bd to 9488819 Compare October 21, 2022 18:07
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@denopink
Copy link
Contributor

everything looks good, merging! 🍻

@denopink denopink merged commit 9e2c2a3 into main Oct 24, 2022
@denopink denopink deleted the renaz6/fixMetricMiddleware branch October 24, 2022 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnabass johnabass johnabass approved these changes

@denopink denopink denopink approved these changes

@schmidtw schmidtw Awaiting requested review from schmidtw

@njharter njharter Awaiting requested review from njharter

Assignees

@renaz6 renaz6

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix Broken FX Integration Merge
3 participants
@renaz6 @denopink @johnabass