feat: WebhookConfig #4
Open
+699
−245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
denopink
commented
Jan 11, 2024
denopink
commented
Jan 11, 2024
denopink
commented
Jan 11, 2024
denopink
commented
Jan 11, 2024
denopink
commented
Jan 11, 2024
webhook.go
Outdated
Comment on lines
44
to
95
| // Config contains data to inform how events are delivered. | ||
| // Deprecated: This field should only be used for backwards compatibility | ||
| // matching. Use ConfigWebhooks instead. | ||
| // Config contains data to inform how events are delivered to single url. | ||
| Config DeliveryConfig `json:"config"` |
There was a problem hiding this comment.
legacy will not use new features (hashing, etc)
create a new Registration for legacy (a separate legacy into it's own v1 api)
denopink
commented
Jan 11, 2024
denopink
commented
Jan 12, 2024
denopink
commented
Jan 16, 2024
denopink
commented
Jan 16, 2024
denopink
commented
Jan 16, 2024
denopink
commented
Jan 16, 2024
webhook.go
Outdated
Comment on lines
76
to
78
| // ID is the configured kafka's name used to map hashed events to. | ||
| // Refer to the Hash substructure configuration for more details. | ||
| ID string `json:"id"` |
denopink
commented
Jan 17, 2024
denopink
commented
Jan 17, 2024
denopink
commented
Jan 17, 2024
denopink
commented
Jan 17, 2024
Bumps [xmidt-org/shared-go](https://github.com/xmidt-org/shared-go) from 4.1.0 to 4.2.0. - [Release notes](https://github.com/xmidt-org/shared-go/releases) - [Commits](xmidt-org/shared-go@5bc4b83...826aa54) --- updated-dependencies: - dependency-name: xmidt-org/shared-go dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [xmidt-org/shared-go](https://github.com/xmidt-org/shared-go) from 4.2.0 to 4.2.2. - [Release notes](https://github.com/xmidt-org/shared-go/releases) - [Commits](xmidt-org/shared-go@826aa54...9e191ce) --- updated-dependencies: - dependency-name: xmidt-org/shared-go dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
johnabass
approved these changes
Aug 6, 2024
denopink
commented
Oct 29, 2024
denopink
force-pushed
the
denopink/feat/webhooks
branch
from
e5cae31 to
5b48a48
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.