updated note part of the Webhook Accept field #73
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #73 +/- ##
=======================================
Coverage 81.98% 81.98%
=======================================
Files 3 3
Lines 333 333
=======================================
Hits 273 273
Misses 60 60
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| An `Accept` of application/octet-stream supports single message return with payload of WRP | ||
| An `Accept` of application/json supports single message return with json form of WRP |
There was a problem hiding this comment.
sounds like batching will only be available for application/jsonl and application/msgpack, that works 👍
There was a problem hiding this comment.
I spoke to John about this & he suggested this set of values for better clarity:
application/wrp+json - one json encoded wrp message
application/wrp+msgpack - one msgpack encoded wrp message
application/wrp+octet-stream - one message with the wrp payload in the http payload
application/wrp+jsonl - multiple jsonl encoded wrp messages
application/wrp+msgpackl - multiple msgpackl encoded wrp messages
There was a problem hiding this comment.
nice! I really like this idea
Discussed with Wes regarding the multipart response for the new
Webhookstruct.Wes said we should not do multipart response. We updated the
Noteportion of theAcceptfield description. Any feedback/questions/discussions on the note or whether or not to do multipart responses are welcome.