-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zap logger updates #874
Zap logger updates #874
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a few suggestions.
Also, there's a few formatting notes like newlines after {}
blocks like if
and for
and func blocks.
Looks like some webpa tests are failing
…common into zap-logger-updates
Codecov Report
@@ Coverage Diff @@
## main #874 +/- ##
=======================================
Coverage 81.83% 81.84%
=======================================
Files 138 138
Lines 8568 8556 -12
=======================================
- Hits 7012 7003 -9
+ Misses 1364 1361 -3
Partials 192 192
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 🍻
SonarCloud Quality Gate failed. |
What's included:
** this won't deprecate webpa-common fully from scytale - but will remove the logging and go-kit features from scytale