Skip to content

Commit

Permalink
patch: update mock181's set, check for non-existing parameters
Browse files Browse the repository at this point in the history
- add case when request param is not found
  • Loading branch information
denopink committed Jul 16, 2024
1 parent fffe243 commit 6c924ef
Showing 1 changed file with 10 additions and 0 deletions.
10 changes: 10 additions & 0 deletions internal/wrphandlers/mocktr181/handler.go
Original file line number Diff line number Diff line change
Expand Up @@ -212,6 +212,7 @@ func (h Handler) set(tr181 *Tr181Payload) (int64, []byte, error) {
)
// Check for any parameters that are not writable.
for _, parameter := range tr181.Parameters {
var found bool
for i := range h.parameters {
mockParameter := &h.parameters[i]
if mockParameter.Name != parameter.Name {
Expand All @@ -220,6 +221,7 @@ func (h Handler) set(tr181 *Tr181Payload) (int64, []byte, error) {

// Check whether mockParameter is writable.
if strings.Contains(mockParameter.Access, "w") {
found = true
// Add mockParameter to the list of parameters to be updated.
writableParams = append(writableParams, mockParameter)
continue
Expand All @@ -231,6 +233,14 @@ func (h Handler) set(tr181 *Tr181Payload) (int64, []byte, error) {
Message: "Parameter is not writable",
})
}

if !found {
// Requested parameter was not found.
failedParams = append(failedParams, Parameter{
Name: parameter.Name,
Message: "Invalid parameter name",
})
}
}

// Check if any parameters failed.
Expand Down

0 comments on commit 6c924ef

Please sign in to comment.