Merge pull request #123 from xmidt-org/add-defaults

feat: add a few sane websocket defaults
xmidt-org · May 15, 2024 · 8323541 · 8323541
2 parents f232afc + 07a96a5
commit 8323541
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/internal/websocket/ws.go b/internal/websocket/ws.go
@@ -113,9 +113,17 @@ func (f optionFunc) apply(c *Websocket) error {
 	return f(c)
 }
 
+func emptyDecorator(http.Header) error {
+	return nil
+}
+
 // New creates a new WS connection with the given options.
 func New(opts ...Option) (*Websocket, error) {
-	var ws Websocket
+	ws := Websocket{
+		credDecorator:   emptyDecorator,
+		conveyDecorator: emptyDecorator,
+		client:          &http.Client{},
+	}
 
 	opts = append(opts,
 		validateDeviceID(),

diff --git a/internal/websocket/ws_test.go b/internal/websocket/ws_test.go
@@ -428,3 +428,7 @@ func TestLimit(t *testing.T) {
 		})
 	}
 }
+
+func Test_emptyDecorator(t *testing.T) {
+	assert.NoError(t, emptyDecorator(http.Header{}))
+}
-Original file line number
+Diff line change
@@ Expand Up / @@ -428,3 +428,7 @@ func TestLimit(t *testing.T) { @@
     		})
     	}
     }
+    func Test_emptyDecorator(t *testing.T) {
+    	assert.NoError(t, emptyDecorator(http.Header{}))
+    }