-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update dockerfile and default config #108
Conversation
piccione99
commented
Apr 23, 2024
•
edited
Loading
edited
- updated default config so we don't need a config file for running docker
- updated readme instructions
- added an example config file for reference
- couldn't get entrypoint.sh to work so currently not using it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the idea makes sense since it's a pattern we already put into practice for our services, i.e.: the service should be able to start with the default config.
However, do we want that to be true for xmidt-agent since it's running on a cpe? Not sure if that's a desired pattern for software running on cpe.
Approving this, but I think we shouldn't merged until @schmidtw chimes in.
Yes, in general we want the app to basically work right out of the box. We also want it to be secure out of the box, too. I will review this later; there are a few parts being built into the configuration that I think we should do via environment variables (the |