Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: #50 add WaitUntilFetched as a configurable value #117

Merged
merged 3 commits into from
May 15, 2024

Conversation

denopink
Copy link
Contributor

@denopink denopink commented May 10, 2024

implements #50

  • Expose the wait time configuration,WaitUntilFetched, controlling how long the agent blocks on startup until an attempt to fetch the credentials has been made.

`WaitUntilFetched` is the time the xmidt-agent blocks on startup until an attempt to fetch the credentials has been made.
@denopink denopink requested review from schmidtw and piccione99 May 10, 2024 17:18
@denopink denopink self-assigned this May 10, 2024
@denopink denopink added the enhancement improvement or small functionality added to an existing feature label May 10, 2024
@schmidtw schmidtw merged commit f232afc into main May 15, 2024
13 of 14 checks passed
@schmidtw schmidtw deleted the denopink/feat/timeout-config-for-cred-fetch branch May 15, 2024 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement improvement or small functionality added to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: determine the timeout default and zero value for cred.WaitUntilFetched(ctx)
2 participants