Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support openfail by default #125

Merged
merged 5 commits into from
May 15, 2024

Conversation

denopink
Copy link
Contributor

implements openfail

  • if the agent's config is missing the xmidt_credentials, then the agent will connect to xmidt via openfail

implements openfail

- if the agent's config is missing the `xmidt_credentials`, then the agent will connect to xmidt via openfail
@denopink denopink added the enhancement improvement or small functionality added to an existing feature label May 15, 2024
@denopink denopink requested review from schmidtw and piccione99 May 15, 2024 17:14
@denopink denopink self-assigned this May 15, 2024
@denopink denopink marked this pull request as draft May 15, 2024 17:14
@denopink denopink marked this pull request as ready for review May 15, 2024 17:14
cmd/xmidt-agent/ws.go Outdated Show resolved Hide resolved
denopink added 4 commits May 15, 2024 13:58
implements openfail

- if the agent's config is missing the `xmidt_credentials`, then the agent will connect to xmidt via openfail
Copy link
Contributor

@piccione99 piccione99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. the real production servers will reject attempts for xmidt-agent to connect?

@schmidtw schmidtw merged commit 201d84e into main May 15, 2024
14 checks passed
@schmidtw schmidtw deleted the denopink/feat/support-openfail-by-default branch May 15, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement improvement or small functionality added to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants