Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refactor providePubSubHandler #126

Merged
merged 4 commits into from
May 15, 2024

Conversation

denopink
Copy link
Contributor

  • refactor providePubSubHandler, moving mocktr181's setup to provideMockTr181Handler

- refactor `providePubSubHandler`, moving  mocktr181 to `provideMockTr181Handler`
@denopink denopink added the enhancement improvement or small functionality added to an existing feature label May 15, 2024
@denopink denopink requested review from schmidtw and piccione99 May 15, 2024 17:32
@denopink denopink self-assigned this May 15, 2024
PubSub *pubsub.PubSub

// wrphandlers
Egress *qos.Handler
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not used.

@schmidtw schmidtw merged commit 55f7bfb into main May 15, 2024
14 checks passed
@schmidtw schmidtw deleted the denopink/refactor/separate-mocktr181-provide branch May 15, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement improvement or small functionality added to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants