refactor: Refactor pubsub package in order to keep defaults consistent #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denopink
added
the
enhancement
denopink
commented
May 16, 2024
Comment on lines
-72
to
-78
| defaults := []Option{ | ||
| WithPublishTimeout(5 * time.Second), | ||
| } | ||
|
|
||
| // Prepend the defaults to the provided options. | ||
| opts = append(defaults, opts...) | ||
|
|
There was a problem hiding this comment.
removing in order to keep things consistent (where our defaults are set), since we already set defaults in cmd/xmidt-agent/config.go
…tup consistent - Refactoring the pubsub package in order to keep defaults setup consistent, since defaults are set in `cmd/xmidt-agent/config.go`
denopink
force-pushed
the
denopink/refactor/pubsub-defaults-consistency-
branch
from
132e98d to
21f2812
Compare
denopink
commented
May 16, 2024
| PublishTimeout: 200 * time.Millisecond, | ||
| PublishTimeout: 5 * time.Second, |
There was a problem hiding this comment.
use the actual pubsub package default 5 * time.Second
denopink
changed the title
schmidtw
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cmd/xmidt-agent/config.go