Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch: fx group behavior differs between lists and non-lists #133

Merged
merged 2 commits into from
May 17, 2024
Merged

patch: fx group behavior differs between lists and non-lists #133

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
64d4a5f
patch: fx group behavior differs between lists and non-lists
denopink May 17, 2024
7c50f14
Merge branch 'main' into denopink/patch/fx-group-behavior-differs-bet…
denopink May 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions cmd/xmidt-agent/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,6 +266,10 @@ func onStop(ws *websocket.Websocket, qos *qos.Handler, shutdowner fx.Shutdowner,
ws.Stop()
qos.Stop()
for _, c := range cancels {
Copy link
Contributor Author

@denopink denopink May 17, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

currently this triggers panics when a wrp handler returns a nil for Cancel func() group:"cancels"

this bug wasn't caught because we weren't returning errors when fx's lifecycle Start/Stop encountered a panic

if c == nil {
continue
}

c()
}

Expand Down
Loading