feat: add a timestamp component to qos in order to prioritize older/newer messages #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ewer messages - 100% test cover for `internal/wrphandlers/qos` - added `PrioritizeOldest` options for qos - if `PrioritizeOldest` is false, then qos will favor the newest message during a qos value tie breaker (vice versa) - Updated `priorityQueue.trim()` to remove messages with the lowest qos value (taking `PrioritizeOldest` into account as well)
denopink
force-pushed
the
denopink/feat/qos-with-timestamp-ordering
branch
from
e525819 to
5e0befb
Compare
denopink
commented
May 29, 2024
| @@ -51,34 +64,69 @@ func (pq *priorityQueue) Enqueue(msg wrp.Message) error { | |||
| return nil | |||
| } | |||
|
|
|||
| // trim removes messages with the lowest QualityOfService (taking `prioritizeOldest` into account) | |||
| // until the queue no longer violates `maxQueueSize“. | |||
| func (pq *priorityQueue) trim() { | |||
There was a problem hiding this comment.
Introduced this since we described a desire to keep messages with higher qos value taking the age of the message into account as well
denopink
commented
May 29, 2024
|
|
||
| // heap.Init() is required since the prioritization was switch to messages with the lowest QualityOfService. | ||
| // The complexity of heap.Init() is O(n) where n = h.Len(). | ||
| heap.Init(pq) |
There was a problem hiding this comment.
If we end up needing to trim often, then the O(n) cost of heap.Init() may start to sting...
I wanted to point that out in case we can't afford the O(n) cost of heap.Init() and we would rather trim() random messages instead.
schmidtw
requested changes
May 29, 2024
schmidtw
requested changes
May 30, 2024
denopink
commented
May 30, 2024
schmidtw
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
internal/wrphandlers/qosPrioritizeOldestoptions for qosPrioritizeOldestis false, then qos will favor the newest message during a qos value tie breaker (vice versa)- UpdatedpriorityQueue.trim()to remove messages with the lowest qos value (takingPrioritizeOldestinto account as well)