Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

patch: update mock181's set to check for non-writable params before updating params and for non-existing parameters #192

Merged
merged 4 commits into from
Jul 18, 2024
Merged

patch: update mock181's set to check for non-writable params before updating params and for non-existing parameters #192

merged 4 commits into from
Jul 18, 2024

Conversation

denopink
Copy link
Contributor

@denopink denopink commented Jul 15, 2024 •
edited
Loading

During mock181's set:

  • check for any non-writable params
  • if any param is not writable, do not update any param
  • add case when request param is not found

@denopink
patch: update mock181's set to check for non-writable params before…
e5df702 
… updating params

During mock181's `set`:
- check for any non-writable params
- if any param is not writable, do not update any param
@denopink denopink requested review from schmidtw and piccione99 July 15, 2024 23:06
@denopink denopink self-assigned this Jul 15, 2024
@denopink denopink added the enhancement improvement or small functionality added to an existing feature label Jul 15, 2024
denopink
denopink commented Jul 15, 2024
View reviewed changes
Copy link
Contributor Author

@denopink denopink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, I'll have to rewrite the tests for mock181 so that it verifies failure cases like rollback was successful during a set failure.

I'll throw that in another pr

@codecov Codecov
Copy link

codecov bot commented Jul 15, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 94.44444% with 2 lines in your changes missing coverage. Please review.

Project coverage is 76.94%. Comparing base (a22907f) to head (6c924ef).
Report is 1 commits behind head on main.

Files Patch % Lines
internal/wrphandlers/mocktr181/handler.go 94.44% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #192      +/-   ##
==========================================
+ Coverage   76.85%   76.94%   +0.09%     
==========================================
  Files          75       75              
  Lines        4510     4528      +18     
==========================================
+ Hits         3466     3484      +18     
- Misses        842      843       +1     
+ Partials      202      201       -1
Flag Coverage Δ
unittests 76.94% <94.44%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@denopink denopink changed the title patch: update mock181's set to check for non-writable params before updating params patch: update mock181's set to check for non-writable params before updating params and for non-existing parameters Jul 16, 2024
@schmidtw schmidtw merged commit ced8a1c into main Jul 18, 2024
18 of 19 checks passed
@schmidtw schmidtw deleted the denopink/patch/mocktr181-set-does-not-rollback branch July 18, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schmidtw schmidtw schmidtw approved these changes

@piccione99 piccione99 Awaiting requested review from piccione99

Assignees

@denopink denopink

Labels
enhancement improvement or small functionality added to an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@denopink @schmidtw