feat: support disableable qos message size validation #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
denopink
commented
Aug 1, 2024
•
denopink
commented
- disableable qos message size validation
- this will match parodus's default behavior
- no individual message size validation
denopink
added
the
enhancement
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #209 +/- ##
==========================================
- Coverage 76.94% 76.93% -0.02%
==========================================
Files 75 75
Lines 4550 4548 -2
==========================================
- Hits 3501 3499 -2
Misses 851 851
Partials 198 198
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
denopink
force-pushed
the
denopink/feat/disableable-qos-message-size-chek
branch
from
ce5d4f8 to
f48fafb
Compare
denopink
changed the title
- disableable qos message size validation - this will match parodus's default behavior - no individual message size validation
denopink
force-pushed
the
denopink/feat/disableable-qos-message-size-chek
branch
from
f48fafb to
5eed84a
Compare
johnabass
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.