Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

populate interface-used with default route #211

Closed
wants to merge 1 commit into from
Closed

populate interface-used with default route #211

wants to merge 1 commit into from

Conversation

piccione99
Copy link
Contributor

The end goal is for the websocket to loop through the connection interfaces and populate the header with the first interface that works. However, there are still some unknowns as to whether or not getting the interface list from the OS will even work. There are also outstanding questions about priority of which interface to try first, etc.. I think we will learn more if we populate the possible interface list from the os and also retrieve the interface for the default route and just send those back initially.

Just my opinion, though. We don't need to merge this. But currently we are hardcoding "erouter0" for every request which is pretty useless.

Copy link

guardrails bot commented Aug 2, 2024

⚠️ We detected 1 security issue in this pull request:

Vulnerable Libraries (1)
Severity Details
High pkg:golang/github.com/nixigaj/[email protected] upgrade to: > v0.0.0-20231019115740-0722aff7ebf3

More info on how to fix Vulnerable Libraries in Go.


👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

Copy link

codecov bot commented Aug 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.97%. Comparing base (31387eb) to head (4b5db21).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #211      +/-   ##
==========================================
+ Coverage   76.94%   76.97%   +0.03%     
==========================================
  Files          75       75              
  Lines        4550     4556       +6     
==========================================
+ Hits         3501     3507       +6     
  Misses        851      851              
  Partials      198      198              
Flag Coverage Δ
unittests 76.97% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@piccione99 piccione99 closed this Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant