-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: connect to xmidt cluster #45
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denopink
commented
Mar 20, 2024
denopink
force-pushed
the
denopink/feat/connect-to-xmidt
branch
from
March 20, 2024 19:32
cc8e6e1
to
6dc3743
Compare
schmidtw
reviewed
Mar 25, 2024
schmidtw
reviewed
Mar 25, 2024
feat: connect to xmidt cluster
denopink
force-pushed
the
denopink/feat/connect-to-xmidt
branch
from
March 28, 2024 23:01
7303ee8
to
5ad7b8b
Compare
schmidtw
approved these changes
Mar 29, 2024
denopink
force-pushed
the
denopink/feat/connect-to-xmidt
branch
from
March 29, 2024 00:16
96c6ae9
to
4ea0f1e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #45 +/- ##
===========================================
- Coverage 80.97% 70.09% -10.89%
===========================================
Files 30 31 +1
Lines 2113 2247 +134
===========================================
- Hits 1711 1575 -136
- Misses 375 639 +264
- Partials 27 33 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
Pending TODOs
ws
provider & config (referred astype Client struct
)