Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: connect to xmidt cluster #45

Merged
merged 3 commits into from
Mar 29, 2024
Merged

Conversation

denopink
Copy link
Contributor

@denopink denopink commented Mar 20, 2024

WIP

Pending TODOs

  • add ws provider & config (referred as type Client struct)
  • add openfail xmidt connection
  • add xmidt connection with jwt

@denopink denopink requested a review from schmidtw March 20, 2024 19:28
@denopink denopink marked this pull request as draft March 20, 2024 19:28
@denopink denopink force-pushed the denopink/feat/connect-to-xmidt branch from cc8e6e1 to 6dc3743 Compare March 20, 2024 19:32
cmd/xmidt-agent/config.go Outdated Show resolved Hide resolved
internal/websocket/ws.go Outdated Show resolved Hide resolved
feat: connect to xmidt cluster
@denopink denopink force-pushed the denopink/feat/connect-to-xmidt branch from 7303ee8 to 5ad7b8b Compare March 28, 2024 23:01
@denopink denopink marked this pull request as ready for review March 28, 2024 23:03
@denopink denopink force-pushed the denopink/feat/connect-to-xmidt branch from 96c6ae9 to 4ea0f1e Compare March 29, 2024 00:16
Copy link

codecov bot commented Mar 29, 2024

Codecov Report

Attention: Patch coverage is 27.82609% with 166 lines in your changes are missing coverage. Please review.

Project coverage is 70.09%. Comparing base (1c24cba) to head (4ea0f1e).
Report is 1 commits behind head on main.

Files Patch % Lines
cmd/xmidt-agent/ws.go 0.00% 58 Missing ⚠️
cmd/xmidt-agent/main.go 34.28% 46 Missing ⚠️
internal/websocket/options.go 16.66% 24 Missing and 6 partials ⚠️
internal/websocket/internal_options.go 57.14% 8 Missing and 4 partials ⚠️
cmd/xmidt-agent/instructions.go 0.00% 11 Missing ⚠️
internal/websocket/ws.go 69.23% 7 Missing and 1 partial ⚠️
cmd/xmidt-agent/credentials.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #45       +/-   ##
===========================================
- Coverage   80.97%   70.09%   -10.89%     
===========================================
  Files          30       31        +1     
  Lines        2113     2247      +134     
===========================================
- Hits         1711     1575      -136     
- Misses        375      639      +264     
- Partials       27       33        +6     
Flag Coverage Δ
unittests 70.09% <27.82%> (-10.89%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@schmidtw schmidtw merged commit 1b1515e into main Mar 29, 2024
14 of 16 checks passed
@schmidtw schmidtw deleted the denopink/feat/connect-to-xmidt branch March 29, 2024 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants