X.H.Screencorners: Add per monitor hot corners #920
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The original implementation of ScreenCorners only allowed hot corners and edges an the corners/ edges of the screen canvas. While this happens to be the same like the corners/ edges of the monitor on a single monitor setup, it is not in a multi monitor setup.
See the screenshot below for a visual explanation:
In the screenshot, the light grey area surrounding all the screen is the canvas. The original Screencorners only allowed hot corners to be placed at the corners and edges of that area. So if a monitor position was shifted down in the y axis, like in the screenshot the monitors HDMI-A-0 and DVI-D-1, the upper left corner could never be reached with the mouse. (Same goes for the lower left and upper/ lower screen edges)
My new implementation deprecates but keeps the functions
addScreenCorner
andaddScreenCorners
to not break the existing configuration of users. It adds the functionsaddMonitorCorner
andaddMonitorCorners
which take a screen corner/edge as before and additionally a monitor number and a dimension.With the monitor number it is possible to place hot corners/ edges an a single monitor. The dimension is important, because before the windows that were the hot areas are only 1x1 pixels wide. They are very hard to hit with the mouse if there are on a corner of a screen in the middle.
Usage is now
addMonitorCorner SCUpperLeft 0 20 (spawn "firefox")
and users that were using theaddScreencorner
function before like thisaddScreenCorner SCUpperLeft (spawn "firefox")
can migrate to this usingaddMonitorCorner SCUpperLeft 0 1 (spawn "firefox")
(if monitor 0 is their leftmost monitor)Checklist
I've read CONTRIBUTING.md
I've considered how to best test these changes (property, unit,
manually, ...) and concluded: Create a hot corner in every corner and edge of every monitor and see if they work.
I updated the
CHANGES.md
file