-
Notifications
You must be signed in to change notification settings - Fork 52
Conversation
Hey i went through the issues to see what is fixed in this PR and i'm listing them below. You can test it out on the app hosted at: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for your interest in building upon our example app! Before adding new functionality, I'd recommend opening up a feature request to talk through why it should be included by default (similar to our contributing guidelines for xmtp-js
). We also encourage developers to customize and maintain their own versions of the example app so that could be another option as well!
I think this has been fixed after the latest changes, if you still see the need for the same we can reopen this PR. Closing it for now |
During development it gets very time consuming to wait for the metamask window and sign the identity messages after page refresh. I replaced
Signer
withWallet
using the private key of a hardhat development wallet.Improves dev experience, not sure if re-asking for signing of identity is necessary in production.
Any thoughts?
For the default private key I think you also need to add the wallet to metamaskhardhat wallet address:
0xf39Fd6e51aad88F6F4ce6aB8827279cffFb92266