Skip to content
This repository has been archived by the owner on Jan 31, 2023. It is now read-only.

autosign metamask messages #85

Closed
wants to merge 29 commits into from
Closed

autosign metamask messages #85

wants to merge 29 commits into from

Conversation

0xlws
Copy link
Contributor

@0xlws 0xlws commented Jul 9, 2022

During development it gets very time consuming to wait for the metamask window and sign the identity messages after page refresh. I replaced Signer with Wallet using the private key of a hardhat development wallet.
Improves dev experience, not sure if re-asking for signing of identity is necessary in production.
Any thoughts?


For the default private key I think you also need to add the wallet to metamask

hardhat wallet address:

0xf39Fd6e51aad88F6F4ce6aB8827279cffFb92266

@0xlws
Copy link
Contributor Author

0xlws commented Jul 12, 2022

Hey i went through the issues to see what is fixed in this PR and i'm listing them below.
Some where already taken care of mostly i guess and i tried to improve on it.
#56 #65 #67 #79

You can test it out on the app hosted at:
xmtp-example.vercel.app/

@saulmc saulmc requested a review from a team July 19, 2022 16:44
Copy link
Contributor

@elisealix22 elisealix22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for your interest in building upon our example app! Before adding new functionality, I'd recommend opening up a feature request to talk through why it should be included by default (similar to our contributing guidelines for xmtp-js). We also encourage developers to customize and maintain their own versions of the example app so that could be another option as well!

@bhavya2611
Copy link
Contributor

I think this has been fixed after the latest changes, if you still see the need for the same we can reopen this PR. Closing it for now

@bhavya2611 bhavya2611 closed this Dec 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants