Skip to content

Lint warning cleanup #16

Lint warning cleanup

Lint warning cleanup #16

Triggered via pull request November 21, 2023 17:37
Status Success
Total duration 6m 12s
Artifacts

lint.yaml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

3 warnings
the borrowed expression implements the required traits: xmtp_proto/src/gen/xmtp.message_contents.serde.rs#L1329
warning: the borrowed expression implements the required traits --> xmtp_proto/src/gen/xmtp.message_contents.serde.rs:1329:86 | 1329 | struct_ser.serialize_field("v1", pbjson::private::base64::encode(&v).as_str())?; | ^^ help: change this to: `v` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
unneeded `return` statement: src/v2.rs#L14
warning: unneeded `return` statement --> src/v2.rs:14:5 | 14 | return Ok(recovered); | ^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return = note: `#[warn(clippy::needless_return)]` on by default help: remove `return` | 14 - return Ok(recovered); 14 + Ok(recovered) |
lint
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/