Apply suggestions from code review

xmtp · Aug 29, 2024 · db0ca10 · db0ca10
1 parent 514225e
commit db0ca10
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/xmtp_mls/src/groups/mod.rs b/xmtp_mls/src/groups/mod.rs
@@ -188,8 +188,8 @@ pub enum GroupError {
     SqlKeyStore(#[from] sql_key_store::SqlKeyStoreError),
     #[error("No pending commit found")]
     MissingPendingCommit,
-    #[error("Sync failed to wait for intent: {0}")]
-    SyncFailedToWait(String),
+    #[error("Sync failed to wait for intent")]
+    SyncFailedToWait,
 }
 
 impl RetryableError for GroupError {

diff --git a/xmtp_mls/src/groups/sync.rs b/xmtp_mls/src/groups/sync.rs
@@ -221,9 +221,8 @@ impl MlsGroup {
             num_attempts += 1;
         }
 
-        Err(last_err.unwrap_or(GroupError::SyncFailedToWait(
-            "failed to wait for intent".to_string(),
-        )))
+        Err(last_err.unwrap_or(GroupError::SyncFailedToWait)
+        ))
     }
 
     fn is_valid_epoch(