Consent Sync

bindings_ffi/Cargo.toml

@@ -17,11 +17,10 @@ uniffi = { version = "0.28.0", default-features = false, features = ["tokio"] }
 xmtp_api_grpc = { path = "../xmtp_api_grpc" }
 xmtp_cryptography = { path = "../xmtp_cryptography" }
 xmtp_id = { path = "../xmtp_id" }
-xmtp_mls = { path = "../xmtp_mls", features = ["message-history"] }
+xmtp_mls = { path = "../xmtp_mls" }
 xmtp_proto = { path = "../xmtp_proto", features = ["proto_full"] }
 xmtp_user_preferences = { path = "../xmtp_user_preferences" }
 xmtp_v2 = { path = "../xmtp_v2" }
-tonic.workspace = true
 
 [build-dependencies]
 uniffi = { version = "0.28.0", features = ["build"] }
@@ -37,7 +36,6 @@ rand.workspace = true
 tokio = { workspace = true, features = ["rt-multi-thread"] }
 uniffi = { version = "0.28.0", features = ["bindgen-tests"] }
 uuid = { workspace = true, features = ["v4", "fast-rng"] }
+xmtp_api_grpc = { path = "../xmtp_api_grpc", features = ["test-utils"] }
 xmtp_mls = { path = "../xmtp_mls", features = ["test-utils"] }
 xmtp_proto = { path = "../xmtp_proto", features = ["test-utils"] }
-xmtp_api_grpc = { path = "../xmtp_api_grpc", features = ["test-utils"] }
-

bindings_ffi/src/mls.rs

@@ -281,7 +281,7 @@ impl FfiXmtpClient {
     ) -> Result<HashMap<String, bool>, GenericError> {
         let inner = self.inner_client.as_ref();
 
-        let results: HashMap<String, bool> = inner.can_message(account_addresses).await?;
+        let results: HashMap<String, bool> = inner.can_message(&account_addresses).await?;
 
         Ok(results)
     }
@@ -353,7 +353,7 @@ impl FfiXmtpClient {
         let stored_records: Vec<StoredConsentRecord> =
             records.into_iter().map(StoredConsentRecord::from).collect();
 
-        inner.set_consent_states(stored_records).await?;
+        inner.set_consent_states(&stored_records).await?;
         Ok(())
     }
 
@@ -398,7 +398,7 @@ impl FfiXmtpClient {
 
     pub async fn request_history_sync(&self) -> Result<(), GenericError> {
         self.inner_client
-            .send_history_request()
+            .send_history_sync_request()
             .await
             .map_err(GenericError::from_error)?;
         Ok(())
@@ -790,7 +790,7 @@ impl FfiConversations {
                 .create_group(group_permissions, metadata_options)?
         } else {
             self.inner_client
-                .create_group_with_members(account_addresses, group_permissions, metadata_options)
+                .create_group_with_members(&account_addresses, group_permissions, metadata_options)
                 .await?
         };
 
@@ -1206,7 +1206,8 @@ impl FfiConversation {
 
     pub async fn add_members(&self, account_addresses: Vec<String>) -> Result<(), GenericError> {
         log::info!("adding members: {}", account_addresses.join(","));
-        self.inner.add_members(account_addresses).await?;
+
+        self.inner.add_members(&account_addresses).await?;
 
         Ok(())
     }
@@ -1216,15 +1217,16 @@ impl FfiConversation {
         inbox_ids: Vec<String>,
     ) -> Result<(), GenericError> {
         log::info!("adding members by inbox id: {}", inbox_ids.join(","));
+
         self.inner
-            .add_members_by_inbox_id(inbox_ids)
+            .add_members_by_inbox_id(&inbox_ids)
             .await
             .map_err(Into::into)
     }
 
     pub async fn remove_members(&self, account_addresses: Vec<String>) -> Result<(), GenericError> {
         self.inner
-            .remove_members(account_addresses)
+            .remove_members(&account_addresses)
             .await
             .map_err(Into::into)
     }
@@ -1233,7 +1235,7 @@ impl FfiConversation {
         &self,
         inbox_ids: Vec<String>,
     ) -> Result<(), GenericError> {
-        self.inner.remove_members_by_inbox_id(inbox_ids).await?;
+        self.inner.remove_members_by_inbox_id(&inbox_ids).await?;
         Ok(())
     }
 

bindings_node/Cargo.toml

@@ -9,16 +9,19 @@ crate-type = ["cdylib"]
 [dependencies]
 # Default enable napi4 feature, see https://nodejs.org/api/n-api.html#node-api-version-matrix
 hex.workspace = true
-napi = { version = "2.12.2", default-features = false, features = ["napi6", "async"] }
+napi = { version = "2.12.2", default-features = false, features = [
+  "napi6",
+  "async",
+] }
 napi-derive = "2.12.2"
-tracing.workspace = true
-tracing-subscriber = { workspace = true, features = ["env-filter", "fmt"] }
 prost.workspace = true
-tokio = { workspace = true, features = ["sync"]}
+tokio = { workspace = true, features = ["sync"] }
+tracing-subscriber = { workspace = true, features = ["env-filter", "fmt"] }
+tracing.workspace = true
 xmtp_api_grpc = { path = "../xmtp_api_grpc" }
 xmtp_cryptography = { path = "../xmtp_cryptography" }
 xmtp_id = { path = "../xmtp_id" }
-xmtp_mls = { path = "../xmtp_mls", features = ["message-history"]}
+xmtp_mls = { path = "../xmtp_mls" }
 xmtp_proto = { path = "../xmtp_proto", features = ["proto_full"] }
 
 [build-dependencies]

bindings_node/src/conversations.rs

@@ -91,7 +91,7 @@ impl NapiConversations {
     } else {
       self
         .inner_client
-        .create_group_with_members(account_addresses, group_permissions, metadata_options)
+        .create_group_with_members(&account_addresses, group_permissions, metadata_options)
         .await
         .map_err(|e| Error::from_reason(format!("ClientError: {}", e)))?
     };

bindings_node/src/groups.rs

@@ -297,7 +297,7 @@ impl NapiGroup {
     );
 
     group
-      .add_members(account_addresses)
+      .add_members(&account_addresses)
       .await
       .map_err(ErrorWrapper::from)?;
 
@@ -386,7 +386,7 @@ impl NapiGroup {
     );
 
     group
-      .add_members_by_inbox_id(inbox_ids)
+      .add_members_by_inbox_id(&inbox_ids)
       .await
       .map_err(ErrorWrapper::from)?;
 
@@ -402,7 +402,7 @@ impl NapiGroup {
     );
 
     group
-      .remove_members(account_addresses)
+      .remove_members(&account_addresses)
       .await
       .map_err(ErrorWrapper::from)?;
 
@@ -418,7 +418,7 @@ impl NapiGroup {
     );
 
     group
-      .remove_members_by_inbox_id(inbox_ids)
+      .remove_members_by_inbox_id(&inbox_ids)
       .await
       .map_err(ErrorWrapper::from)?;
 

bindings_node/src/mls_client.rs

@@ -172,7 +172,7 @@ impl NapiClient {
   pub async fn can_message(&self, account_addresses: Vec<String>) -> Result<HashMap<String, bool>> {
     let results: HashMap<String, bool> = self
       .inner_client
-      .can_message(account_addresses)
+      .can_message(&account_addresses)
       .await
       .map_err(ErrorWrapper::from)?;
 
@@ -228,7 +228,7 @@ impl NapiClient {
   pub async fn request_history_sync(&self) -> Result<()> {
     let _ = self
       .inner_client
-      .send_history_request()
+      .send_history_sync_request()
       .await
       .map_err(ErrorWrapper::from);
 
@@ -411,7 +411,7 @@ impl NapiClient {
       records.into_iter().map(StoredConsentRecord::from).collect();
 
     inner
-      .set_consent_states(stored_records)
+      .set_consent_states(&stored_records)
       .await
       .map_err(ErrorWrapper::from)?;
     Ok(())

bindings_wasm/Cargo.toml

@@ -18,18 +18,9 @@ wasm-bindgen.workspace = true
 xmtp_api_http = { path = "../xmtp_api_http" }
 xmtp_cryptography = { path = "../xmtp_cryptography" }
 xmtp_id = { path = "../xmtp_id" }
-xmtp_mls = { path = "../xmtp_mls", features = [
-  "message-history",
-  "test-utils",
-  "http-api"
-] }
+xmtp_mls = { path = "../xmtp_mls", features = ["test-utils", "http-api"] }
 xmtp_proto = { path = "../xmtp_proto", features = ["proto_full"] }
 
 [dev-dependencies]
 wasm-bindgen-test.workspace = true
-xmtp_mls = { path = "../xmtp_mls", features = [
-  "message-history",
-  "test-utils",
-  "http-api"
-] }
-
+xmtp_mls = { path = "../xmtp_mls", features = ["test-utils", "http-api"] }

bindings_wasm/src/conversations.rs

@@ -122,7 +122,7 @@ impl WasmConversations {
     } else {
       self
         .inner_client
-        .create_group_with_members(account_addresses, group_permissions, metadata_options)
+        .create_group_with_members(&account_addresses, group_permissions, metadata_options)
         .await
         .map_err(|e| JsError::new(format!("{}", e).as_str()))?
     };

bindings_wasm/src/groups.rs

@@ -296,7 +296,7 @@ impl WasmGroup {
     );
 
     group
-      .add_members(account_addresses)
+      .add_members(&account_addresses)
       .await
       .map_err(|e| JsError::new(&format!("{e}")))?;
 
@@ -387,7 +387,7 @@ impl WasmGroup {
     );
 
     group
-      .add_members_by_inbox_id(inbox_ids)
+      .add_members_by_inbox_id(&inbox_ids)
       .await
       .map_err(|e| JsError::new(&format!("{e}")))?;
 
@@ -403,7 +403,7 @@ impl WasmGroup {
     );
 
     group
-      .remove_members(account_addresses)
+      .remove_members(&account_addresses)
       .await
       .map_err(|e| JsError::new(&format!("{e}")))?;
 
@@ -419,7 +419,7 @@ impl WasmGroup {
     );
 
     group
-      .remove_members_by_inbox_id(inbox_ids)
+      .remove_members_by_inbox_id(&inbox_ids)
       .await
       .map_err(|e| JsError::new(&format!("{e}")))?;
 

bindings_wasm/src/mls_client.rs

@@ -122,7 +122,7 @@ impl WasmClient {
   pub async fn can_message(&self, account_addresses: Vec<String>) -> Result<JsValue, JsError> {
     let results: HashMap<String, bool> = self
       .inner_client
-      .can_message(account_addresses)
+      .can_message(&account_addresses)
       .await
       .map_err(|e| JsError::new(format!("{}", e).as_str()))?;
 
@@ -289,7 +289,7 @@ impl WasmClient {
   pub async fn request_history_sync(&self) -> Result<(), JsError> {
     let _ = self
       .inner_client
-      .send_history_request()
+      .send_history_sync_request()
       .await
       .map_err(|e| JsError::new(format!("{}", e).as_str()))?;
 
@@ -345,7 +345,7 @@ impl WasmClient {
       records.into_iter().map(StoredConsentRecord::from).collect();
 
     inner
-      .set_consent_states(stored_records)
+      .set_consent_states(&stored_records)
       .await
       .map_err(|e| JsError::new(format!("{}", e).as_str()))?;
     Ok(())

examples/cli/Cargo.toml

@@ -33,5 +33,5 @@ tokio = "1.28.1"
 xmtp_api_grpc = { path = "../../xmtp_api_grpc" }
 xmtp_cryptography = { path = "../../xmtp_cryptography" }
 xmtp_id = { path = "../../xmtp_id" }
-xmtp_mls = { path = "../../xmtp_mls", features = ["message-history"]}
+xmtp_mls = { path = "../../xmtp_mls" }
 xmtp_proto = { path = "../../xmtp_proto", features = ["proto_full"] }