Remove Purpose, Add Conversation Type to database. Sync sync groups when syncing all groups too. #1261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codabrink
changed the title
codabrink
commented
Nov 13, 2024
| // Otherwise filter sync groups out by default. | ||
| if !matches!(conversation_type, Some(ConversationType::Sync)) && !include_sync_groups { | ||
| query = query.filter(groups_dsl::conversation_type.ne(ConversationType::Sync)); | ||
| } |
There was a problem hiding this comment.
Aside from removing Purpose and adding ConversationType to the db, here's the main change of this PR.
No longer unconditionally filtering out Sync groups, however we still filter them out by default.
codabrink
force-pushed
the
coda/sync-cleanup
branch
from
cfdf224 to
da7b64a
Compare
cameronvoell
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purposefrom the db (and the codebase)ConversationTypecolumn in the db