Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Live Consent Sync (#1234)" #1288

Merged
merged 2 commits into from
Nov 19, 2024
Merged

Revert "Live Consent Sync (#1234)" #1288

merged 2 commits into from
Nov 19, 2024
+1,350 −1,981

Conversation

nplasterer
Copy link
Contributor

This reverts commit 0b0bcde.

@nplasterer nplasterer self-assigned this Nov 19, 2024
@nplasterer
Copy link
Contributor Author

nplasterer commented Nov 19, 2024 •
edited
Loading

Tests take milliseconds again after reverting this PR

Screenshot 2024-11-18 at 5 11 46 PM

Previously

Screenshot 2024-11-18 at 5 16 35 PM

@nplasterer nplasterer marked this pull request as ready for review November 19, 2024 01:13
@nplasterer nplasterer requested a review from a team as a code owner November 19, 2024 01:13
cameronvoell
cameronvoell approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@cameronvoell cameronvoell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verified seeing similar slower tests on my end

@nplasterer nplasterer merged commit 46e3bc7 into main Nov 19, 2024
15 checks passed
@nplasterer nplasterer deleted the np/performance-revert branch November 19, 2024 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cameronvoell cameronvoell cameronvoell approved these changes

Assignees

@nplasterer nplasterer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nplasterer @cameronvoell