Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share provider everywhere #1390

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Share provider everywhere #1390

merged 1 commit into from
Dec 9, 2024

Conversation

insipx
Copy link
Contributor

@insipx insipx commented Dec 6, 2024

  • Transactions take a &XmtpOpenMlsProvider
  • Methods that previously pulled a connection take a provider
  • process_for_id removed, and inlined where it was used
    • the closure & indirection proved too complicated to figure out the lifetimes for. It also seemed to be too much indirection for only a couple lines of code
    • inlined into consume_message
    • created process_new_welcome
    • these use transaction_async directly and share a &XmtpOpenMlsProvider

@insipx insipx requested a review from a team as a code owner December 6, 2024 18:29
@insipx insipx force-pushed the insipx/connection-optimization branch from 5e9d0fb to ebc8037 Compare December 6, 2024 18:40
@insipx insipx force-pushed the insipx/connection-optimization branch from ebc8037 to 6797962 Compare December 6, 2024 19:44
@insipx insipx merged commit 4524216 into main Dec 9, 2024
15 checks passed
@insipx insipx deleted the insipx/connection-optimization branch December 9, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants