Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync All Preference Updates Across Devices #1400

Merged
merged 31 commits into from
Dec 13, 2024
Merged

Sync All Preference Updates Across Devices #1400

merged 31 commits into from
Dec 13, 2024

Conversation

codabrink
Copy link
Contributor

@codabrink codabrink commented Dec 10, 2024 •
edited
Loading

Issue: #1380

  • Harden consent sync ordering by relying on MLS for ordering
  • Sync user preferences (includes HMAC keys) across all devices
  • Add worker handle so we can be notified when certain jobs complete

@codabrink codabrink linked an issue Dec 11, 2024 that may be closed by this pull request
Harden Consent Update Sync Ordering #1308
Closed
@codabrink codabrink marked this pull request as ready for review December 12, 2024 20:12
@codabrink codabrink requested a review from a team as a code owner December 12, 2024 20:12
insipx
insipx approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@insipx insipx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

xmtp_mls/src/groups/device_sync.rs Show resolved Hide resolved
xmtp_mls/src/storage/encrypted_store/user_preferences.rs Show resolved Hide resolved
@codabrink codabrink enabled auto-merge (squash) December 13, 2024 03:28
@codabrink codabrink merged commit bd03cd7 into main Dec 13, 2024
26 checks passed
@codabrink codabrink deleted the coda/hmac-sync branch December 13, 2024 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@insipx insipx insipx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Harden Consent Update Sync Ordering
2 participants
@codabrink @insipx