Expose installation ID bytes when calling inboxState (node + WASM bindings)
#1473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
insipx
approved these changes
Jan 6, 2025
richardhuaaa
approved these changes
Jan 6, 2025
| @@ -231,7 +230,7 @@ impl Conversation { | |||
| installation_ids: member | |||
| .installation_ids | |||
| .into_iter() | |||
| .map(|id| ed25519_public_key_to_address(id.as_slice())) | |||
There was a problem hiding this comment.
Double-checking, the ID here is bytes and not string right?
rygine
force-pushed
the
rygine/bindings-bytes-to-hex
branch
from
8b5443b to
39d70ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
bytesfield to installation data when callinginboxStateon clientsSince encoded installation ID strings can't be reversed back into bytes, we need a way to expose installation bytes so that we can use them when revoking specific installations.