Backup your account without a second device #1479
Conversation
codabrink
force-pushed
the
coda/backups
branch
from
a30393e to
ab3f8e9
Compare
codabrink
force-pushed
the
coda/backups
branch
3 times, most recently
from
ff524ac to
6a2b7d0
Compare
codabrink
force-pushed
the
coda/backups
branch
from
6a2b7d0 to
f4e0a40
Compare
codabrink
force-pushed
the
coda/backups
branch
from
258b2d1 to
7912ab1
Compare
codabrink
force-pushed
the
coda/backups
branch
from
ed53c1e to
7b98367
Compare
| } | ||
|
|
||
| impl BackupOptions { | ||
| #[cfg(not(target_arch = "wasm32"))] |
There was a problem hiding this comment.
what's the plan for web support/how would i use this from the web?
There was a problem hiding this comment.
Just like how we have a handler that consumes the AsyncRead to a file for native here, we'd want to do something similar on the browser file handle.
| pub use backup_importer::BackupImporter; | ||
|
|
||
| // Increment on breaking changes | ||
| const BACKUP_VERSION: u32 = 0; |
There was a problem hiding this comment.
what qualifies as a breaking change where we need to increment this?
There was a problem hiding this comment.
If we add a new optional field to one of the structs that's exported, we'd want to put some logic on the importer that says something like... If backup_version < 1, set new field to this default value, otherwise leave it be or maybe use this separate hydrater entirely. That's just one example. Really this is just a field that I'm sure will be useful to delineate between updates, and make importing old archives possible.
Proto: xmtp/proto#239